OneSizeFitsQuorum commented on code in PR #8654:
URL: https://github.com/apache/iotdb/pull/8654#discussion_r1062114440
##########
node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java:
##########
@@ -99,13 +99,14 @@ public class CommonConfig {
* ClientManager will have so many selector threads (TAsyncClientManager) to
distribute to its
* clients.
*/
- private int selectorNumOfClientManager =
- Runtime.getRuntime().availableProcessors() / 4 > 0
- ? Runtime.getRuntime().availableProcessors() / 4
- : 1;
+ private int selectorNumOfClientManager = 1;
/** whether to use thrift compression. */
- private boolean isCnRpcThriftCompressionEnabled = false;
+ private boolean isRpcThriftCompressionEnabled = false;
+
+ private int maxTotalClientForEachNode = 300;
+
+ private int maxIdleClientForEachNode = 200;
Review Comment:
Current thrift related parameters are placed in a separate configuration
file for confignode/datanode. This ensures that confignode and datanode can use
different thrift parameters in a distribution package.
To keep up with the current status, I load different parameters for the same
variable in CommonDescriptor, which is ugly but ensures that any process can
set the parameters correctly to initialize the clientPool with the correct
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
