OneSizeFitsQuorum commented on code in PR #9147:
URL: https://github.com/apache/iotdb/pull/9147#discussion_r1118414954
##########
metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java:
##########
@@ -57,14 +58,16 @@ public class MetricConfig {
/** The type of internal reporter. */
private InternalReporterType internalReporterType =
InternalReporterType.IOTDB;
- /** The address of iotdb instance that is monitored. */
- private String rpcAddress = "0.0.0.0";
- /** The port of iotdb instance that is monitored. */
- private Integer rpcPort = 6667;
/** The pid of iotdb instance. */
private String pid = "";
- /** The running system of iotdb instance */
+ /** The running system of iotdb instance. */
private final SystemType systemType = SystemType.getSystemType();
+ /** The type of monitored node */
+ private NodeType nodeType = NodeType.CONFIGNODE;
+ /** The name of iotdb cluster. */
+ private String clusterName = "iotdb-cluster";
Review Comment:
default?
##########
metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java:
##########
@@ -57,14 +58,16 @@ public class MetricConfig {
/** The type of internal reporter. */
private InternalReporterType internalReporterType =
InternalReporterType.IOTDB;
- /** The address of iotdb instance that is monitored. */
- private String rpcAddress = "0.0.0.0";
- /** The port of iotdb instance that is monitored. */
- private Integer rpcPort = 6667;
/** The pid of iotdb instance. */
private String pid = "";
- /** The running system of iotdb instance */
+ /** The running system of iotdb instance. */
private final SystemType systemType = SystemType.getSystemType();
+ /** The type of monitored node */
Review Comment:
.
##########
docs/UserGuide/Monitor-Alert/Metric-Tool.md:
##########
@@ -757,15 +757,15 @@ data source for Apache IoTDB Dashboard.
#### 5.3.1. IoTDB mapping relationship of metrics
> For metrics whose Metric Name is name and Tags are K1=V1, ..., Kn=Vn, the
> mapping is as follows, taking root.__
-> system.metric.`ip:port` as an example by default
-
-| Metric Type | Mapping
|
-| ---------------- |
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
-| Counter |
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.value
|
-| AutoGauge、Gauge |
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.value
|
-| Histogram |
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.count <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.max <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.sum <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p0 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p50 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p75 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p99 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p999
|
-| Rate |
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.count <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.mean <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.m1 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.m5 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.m15
|
-| Timer |
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.count <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.max <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.mean <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.sum <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p0 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p50 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p75 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p99 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.p999 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.m1 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.m5 <br>
root.__system.metric.`ip:port`.name.`K1=V1`...`Kn=Vn`.m15 |
+> system.metric.`clusterName`.`nodeId` as an example by default
+
+| Metric Type | Mapping
|
+| ---------------- |
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
+| Counter |
root.__system.metric.`clusterName`.`nodeId`.name.`K1=V1`...`Kn=Vn`.value
|
+| AutoGauge、Gauge |
root.__system.metric.`clusterName`.`nodeId`.name.`K1=V1`...`Kn=Vn`.value
|
Review Comment:
`clusterName`.`nodeId`.`nodetype`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
