ycycse commented on code in PR #9141: URL: https://github.com/apache/iotdb/pull/9141#discussion_r1123322847
########## server/src/main/java/org/apache/iotdb/db/mpp/aggregation/slidingwindow/SlidingWindowAggregator.java: ########## @@ -54,7 +54,7 @@ protected SlidingWindowAggregator( } @Override Review Comment: If SlidingWindowAggregator doesn't extends Aggregator, there will be more common codes appear in SlidingWindowAggregator (and SlidingWindowAggregationOperator needs to be modified, too). So I just choose to delete the sliding-window-method in Aggregator and add a type cast in SlidingWindowAggregationOperator now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
