Wei-hao-Li commented on code in PR #9226:
URL: https://github.com/apache/iotdb/pull/9226#discussion_r1127259339
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ExpressionAnalyzer.java:
##########
@@ -1324,8 +1324,8 @@ public static boolean
isDeviceViewNeedSpecialProcess(Expression expression) {
} else if (expression instanceof UnaryExpression) {
return isDeviceViewNeedSpecialProcess(((UnaryExpression)
expression).getExpression());
} else if (expression instanceof FunctionExpression) {
- if (((FunctionExpression) expression).isBuiltInFunction()
- && BuiltinFunction.DEVICE_VIEW_SPECIAL_PROCESS_FUNCTIONS.contains(
+ if (((FunctionExpression) expression).isBuiltInScalarFunction()
Review Comment:
> Previously, we named it as BuiltInScalarFunction, but I've forgot why
Weihao Li changed it, you need to discuss with him @Wei-hao-Li
In previous discuss, we assume maybe not all BuiltinFunctions are scalar,
and we use the interface `is Mappable` to identify if it is mappable. For
example, if we want to implement the function `distinct()`, it cannot be think
as 'BuiltInAggregation' or 'BuiltInScalar'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
