liyuheng55555 commented on code in PR #9236: URL: https://github.com/apache/iotdb/pull/9236#discussion_r1129163663
########## server/src/main/java/org/apache/iotdb/db/mpp/plan/expression/visitor/CollectVisitor.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.mpp.plan.expression.visitor; + +import org.apache.iotdb.db.mpp.plan.expression.Expression; +import org.apache.iotdb.db.mpp.plan.expression.binary.BinaryExpression; +import org.apache.iotdb.db.mpp.plan.expression.leaf.LeafOperand; +import org.apache.iotdb.db.mpp.plan.expression.ternary.TernaryExpression; +import org.apache.iotdb.db.mpp.plan.expression.unary.UnaryExpression; + +import java.util.ArrayList; +import java.util.List; + +/** + * Simply collects result from child-expression. For example, two child give me 3 and 4 results, I + * will return 3+4 = 7 results to upper level. + */ +public class CollectVisitor extends ExpressionAnalyzeVisitor<List<Expression>, Void> { Review Comment: done. ########## server/src/main/java/org/apache/iotdb/db/mpp/plan/expression/visitor/ReconstructVisitor.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.mpp.plan.expression.visitor; + +import org.apache.iotdb.db.mpp.plan.expression.Expression; +import org.apache.iotdb.db.mpp.plan.expression.binary.BinaryExpression; +import org.apache.iotdb.db.mpp.plan.expression.leaf.LeafOperand; +import org.apache.iotdb.db.mpp.plan.expression.ternary.TernaryExpression; +import org.apache.iotdb.db.mpp.plan.expression.unary.UnaryExpression; + +import java.util.ArrayList; +import java.util.List; + +import static org.apache.iotdb.db.mpp.plan.analyze.ExpressionUtils.reconstructAllKindsOfExpression; + +/** + * Collect result from child, then reconstruct. For example, two child each give me 1 result, I + * should use them to reconstruct 1 new result to upper level. + */ +public class ReconstructVisitor<C> extends ExpressionAnalyzeVisitor<Expression, C> { Review Comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
