OneSizeFitsQuorum commented on code in PR #9439:
URL: https://github.com/apache/iotdb/pull/9439#discussion_r1147330292
##########
server/src/main/java/org/apache/iotdb/db/service/metrics/IoTDBInternalLocalReporter.java:
##########
@@ -150,39 +150,43 @@ public ReporterType getReporterType() {
@Override
protected void writeMetricToIoTDB(Map<String, Object> valueMap, String
prefix, long time) {
- try {
- TSInsertRecordReq request = new TSInsertRecordReq();
- List<String> measurements = new ArrayList<>();
- List<TSDataType> types = new ArrayList<>();
- List<Object> values = new ArrayList<>();
- for (Map.Entry<String, Object> entry : valueMap.entrySet()) {
- String measurement = entry.getKey();
- Object value = entry.getValue();
- measurements.add(measurement);
- types.add(inferType(value));
- values.add(value);
- }
- ByteBuffer buffer = SessionUtils.getValueBuffer(types, values);
+ service.execute(
Review Comment:
First, the autoguage map is currently always empty and will not actually
start writing, only flush points are currently called.
In addition, even if the autoguage map is not empty in the future, the queue
of the thread pool is a DelayQueue and will never be filled, and each task does
not block waiting for the execution of subtasks, so this does not constitute a
deadlock condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
