JackieTien97 commented on code in PR #9674:
URL: https://github.com/apache/iotdb/pull/9674#discussion_r1175220911
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/parser/StatementGenerator.java:
##########
@@ -208,7 +208,7 @@ public static Statement
createStatement(TSAggregationQueryReq req, ZoneId zoneId
SelectComponent selectComponent = new SelectComponent(zoneId);
List<PartialPath> selectPaths = new ArrayList<>();
for (String pathStr : req.getPaths()) {
- selectPaths.add(new PartialPath(pathStr));
+ selectPaths.add(new PartialPath(pathStr.split("\\.")));
Review Comment:
We cannot directly use `String.split` unless user point it out.
##########
server/src/main/java/org/apache/iotdb/db/query/context/QueryContext.java:
##########
@@ -93,6 +93,8 @@ public QueryContext(long queryId, boolean debug, long
startTime, String statemen
* them from 'modFile' and put then into the cache.
*/
public List<Modification> getPathModifications(ModificationFile modFile,
PartialPath path) {
+ // TODO if no delete operation exists globally, return emptyList
Review Comment:
```suggestion
// TODO change a way to do the existing check to avoid this IO call each
time.
```
##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -366,6 +366,10 @@ cluster_name=defaultCluster
# Datatype: boolean
# meta_data_cache_enable=true
+# Whether to enable query metrics monitoring or not. Enable this may cause a
little query performance degradation.
+# Datatype: boolean
+# query_metric_enable = true
Review Comment:
I remember that @OneSizeFitsQuorum has already added a new level metric
level which means no metrics at all, i think you can use that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
