OneSizeFitsQuorum commented on code in PR #9768:
URL: https://github.com/apache/iotdb/pull/9768#discussion_r1186072318
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FragmentInstanceDispatcherImpl.java:
##########
@@ -268,11 +270,15 @@ private void dispatchRemote(FragmentInstance instance,
TEndPoint endPoint)
}
break;
case WRITE:
- TSendPlanNodeReq sendPlanNodeReq =
- new TSendPlanNodeReq(
- new
TPlanNode(instance.getFragment().getPlanNodeTree().serializeToByteBuffer()),
- instance.getRegionReplicaSet().getRegionId());
- TSendPlanNodeResp sendPlanNodeResp =
client.sendPlanNode(sendPlanNodeReq);
+ TSendBatchPlanNodeReq sendPlanNodeReq =
Review Comment:
I think batch means that there is more than or equal to one. Writing two
interfaces in thrift for the same logic results in more redundant code on the
sender and receiver...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
