chrisdutz commented on code in PR #10893:
URL: https://github.com/apache/iotdb/pull/10893#discussion_r1298356169


##########
pom.xml:
##########
@@ -1291,6 +1299,17 @@
                                     <generator>java</generator>
                                 </configuration>
                             </execution>
+                            <execution>
+                                <id>generate-thrift-sources-nodejs</id>

Review Comment:
   Admittedly this branch was never meant for being merged ... I used it to 
test my externalized thrift binaries and as I updated them to also contain the 
JS compiler, this was more added as a test for that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to