liyuheng55555 commented on code in PR #10924:
URL: https://github.com/apache/iotdb/pull/10924#discussion_r1301226590
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java:
##########
@@ -559,8 +559,13 @@ private TSStatus autoExtendRegionGroupIfNecessary(
(int)
Math.min(
unassignedPartitionSlotsCount, minRegionGroupNum -
allocatedRegionGroupCount);
- allotmentMap.put(database, delta);
- continue;
+ if (slotCount <= (maxSlotCount / maxRegionGroupCount) *
minRegionGroupNum) {
Review Comment:
Perhaps this condition should be moved to line 555,
"allocatedRegionGroupCount < minRegionGroupNum && slotCount <= (maxSlotCount /
maxRegionGroupCount) * minRegionGroupNum".
Besides, it would be better to keep the name of minRegionGroup**Num** and
maxRegionGroup**Count** consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
