xingtanzjr commented on code in PR #10919:
URL: https://github.com/apache/iotdb/pull/10919#discussion_r1302451749
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/fast/SeriesCompactionExecutor.java:
##########
@@ -276,7 +277,9 @@ private void compactWithNonOverlapPage(PageElement
pageElement)
} else {
// unsealed page is not large enough or page.endTime > file.endTime,
then deserialze it
summary.pageNoneOverlapButDeserialize += 1;
Review Comment:
Should this summary be considered inside the following `if` ?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/fast/SeriesCompactionExecutor.java:
##########
@@ -244,8 +244,9 @@ private void compactPages()
|| firstPageElement.needForceDecoding) {
// has overlap or modified pages, then deserialize it
summary.pageOverlapOrModified += 1;
Review Comment:
Should this summary be considered inside the following `if` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
