caozj1011 commented on code in PR #10982:
URL: https://github.com/apache/iotdb/pull/10982#discussion_r1308458591
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/CompactionUtils.java:
##########
@@ -439,54 +440,30 @@ public static boolean
validateSingleTsFiles(TsFileResource resource) {
public static void deleteSourceTsFileAndUpdateFileMetrics(
List<TsFileResource> sourceSeqResourceList, List<TsFileResource>
sourceUnseqResourceList) {
- // delete seq file
- deleteSourceTsFileAndUpdateFileMetrics(sourceSeqResourceList);
-
- // delete unSeq file
- long[] unSequenceFileSize = new long[sourceUnseqResourceList.size()];
- List<String> unSequenceFileNames = new ArrayList<>();
- boolean removeSuccess = true;
- for (int i = 0; i < sourceUnseqResourceList.size(); i++) {
- TsFileResource tsFileResource = sourceUnseqResourceList.get(i);
- if (!tsFileResource.remove()) {
- removeSuccess = false;
- logger.warn(
- "[Compaction] delete unSequence file failed,file path is {}",
- tsFileResource.getTsFile().getAbsolutePath());
- } else {
- logger.info(
- "[Compaction] delete unSequence file :{}",
- tsFileResource.getTsFile().getAbsolutePath());
- unSequenceFileSize[i] = tsFileResource.getTsFileSize();
- unSequenceFileNames.add(tsFileResource.getTsFile().getName());
- }
- }
- if (removeSuccess) {
- FileMetrics.getInstance().deleteFile(unSequenceFileSize, false,
unSequenceFileNames);
- }
+ deleteSourceTsFileAndUpdateFileMetrics(sourceSeqResourceList, true);
+ deleteSourceTsFileAndUpdateFileMetrics(sourceUnseqResourceList, false);
}
public static void deleteSourceTsFileAndUpdateFileMetrics(
- List<TsFileResource> sourceSeqResourceList) {
- long[] sequenceFileSize = new long[sourceSeqResourceList.size()];
- List<String> sequenceFileNames = new ArrayList<>();
- boolean removeSuccess = true;
- for (int i = 0; i < sourceSeqResourceList.size(); i++) {
- TsFileResource tsFileResource = sourceSeqResourceList.get(i);
- if (!tsFileResource.remove()) {
- removeSuccess = false;
+ List<TsFileResource> resources, boolean seq) {
+ long[] fileSizes = new long[resources.size()];
Review Comment:
Can this object be omitted and replaced by `fileNames.size()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
