caozj1011 commented on code in PR #11454:
URL: https://github.com/apache/iotdb/pull/11454#discussion_r1381208623
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/AbstractCompactionTask.java:
##########
@@ -372,21 +374,56 @@ public boolean isDiskSpaceCheckPassed() {
return CompactionUtils.isDiskHasSpace();
}
- protected void validateTsFileResource(
- List<TsFileResource> targetTsFileList, boolean needValidateOverlap) {
+ protected void validateCompactionResult(
+ List<TsFileResource> sourceSeqFiles,
+ List<TsFileResource> sourceUnseqFiles,
+ List<TsFileResource> targetFiles)
+ throws CompactionValidationFailedException {
+ // skip TsFileResource which is marked as DELETED status
+ List<TsFileResource> validTargetFiles =
+ targetFiles.stream().filter(resource ->
!resource.isDeleted()).collect(Collectors.toList());
+ CompactionTaskType taskType = getCompactionTaskType();
+ boolean needToValidateTsFileCorrectness = taskType !=
CompactionTaskType.INSERTION;
Review Comment:
These **CompactionTaskType** are supposed to be specified by task new or
another step, but I can't find a place to assign a value to the task, make sure
the task corresponds to its task type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
