Caideyipi commented on code in PR #11457:
URL: https://github.com/apache/iotdb/pull/11457#discussion_r1385940176
##########
iotdb-client/jdbc/src/test/java/org/apache/iotdb/jdbc/UtilsTest.java:
##########
@@ -65,6 +65,31 @@ public void testParseURL() throws IoTDBURLException {
assertEquals(params.getPassword(), userPwd);
}
+ @Test
+ public void testParseIPV6URL() throws IoTDBURLException {
+ String userName = "test";
+ String userPwd = "test";
+ String host1 =
+
"AD80:E32B:CR25:B3WE:DG4G:DWTF:EEWE:BBBE,AD80:E32B:CR25:B3WE:DG4G:DWTF:CGDE:EEWE:BBBE,AD80:E32B:CR25:B3WE:DG4G:DWTF:EEWE:BBBE";
Review Comment:
This can still be A-F~
##########
iotdb-core/node-commons/src/test/java/org/apache/iotdb/commons/utils/NodeUrlUtilsTest.java:
##########
@@ -59,4 +59,37 @@ public void parseAndConvertTConfigNodeUrlsTest() throws
BadNodeUrlException {
Assert.assertEquals(configNodeUrls,
NodeUrlUtils.convertTConfigNodeUrls(configNodeLocations));
Assert.assertEquals(configNodeLocations,
NodeUrlUtils.parseTConfigNodeUrls(configNodeUrls));
}
+
+ @Test
+ public void parseAndConvertTEndPointUrlsIPV4AndIPV6Test() throws
BadNodeUrlException {
+ final List<TEndPoint> endPoints =
+ Arrays.asList(
+ new TEndPoint("AD80:E32B:CR25:B3WE:DG4G:DWTF:CGDE:2345", 6667),
+ new TEndPoint("0:0:0:0:0:FFFF:129.144.52.38", 6668),
+ new TEndPoint("::13.1.68.3", 6669));
+ final String endPointUrls =
+
"AD80:E32B:CR25:B3WE:DG4G:DWTF:CGDE:2345:6667,[0:0:0:0:0:FFFF:129.144.52.38]:6668,[::13.1.68.3]:6669";
Review Comment:
This can still be A-F~ and the same for the other functions in the very file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
