Caideyipi commented on code in PR #11489:
URL: https://github.com/apache/iotdb/pull/11489#discussion_r1385964695
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/IoTDBConnector.java:
##########
@@ -53,6 +61,11 @@ public abstract class IoTDBConnector implements
PipeConnector {
protected boolean isTabletBatchModeEnabled = true;
+ protected final AtomicLong commitIdGenerator = new AtomicLong(0);
Review Comment:
To ensure the ordering of the commiting across connectors, it may be better
to make the 3 variables static, to let all the connectors share one commitId
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/IoTDBConnector.java:
##########
@@ -125,4 +138,39 @@ protected Set<TEndPoint> parseNodeUrls(PipeParameters
parameters) {
return givenNodeUrls;
}
+
+ /**
Review Comment:
I deem it better to do another abstract upon the "IoTDBConnector", and make
all the connectors need commiting extend it. Therefore we can avoid
duplicateing the commit logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
