caozj1011 commented on code in PR #11556:
URL: https://github.com/apache/iotdb/pull/11556#discussion_r1400108765
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java:
##########
@@ -472,6 +487,9 @@ public SyncBufferTask(
@Override
public void run() {
Review Comment:
The logic of the run() method suggests that it might be encapsulated in two
parts, one for checkPoint, like the makeMemTableCheckpoints() method, and
another for Wal. If the rest of the code is also encapsulated as a function,
the code will look very clean and organized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
