Caideyipi commented on code in PR #11601: URL: https://github.com/apache/iotdb/pull/11601#discussion_r1404088714
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/PipeEventCommitMetrics.java: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.pipe.metric; + +import org.apache.iotdb.commons.service.metric.enums.Metric; +import org.apache.iotdb.commons.service.metric.enums.Tag; +import org.apache.iotdb.db.pipe.commit.PipeEventCommitter; +import org.apache.iotdb.metrics.AbstractMetricService; +import org.apache.iotdb.metrics.metricsets.IMetricSet; +import org.apache.iotdb.metrics.utils.MetricLevel; +import org.apache.iotdb.metrics.utils.MetricType; + +import com.google.common.collect.ImmutableSet; +import org.checkerframework.checker.nullness.qual.NonNull; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Map; +import java.util.Objects; +import java.util.concurrent.ConcurrentHashMap; + +public class PipeEventCommitMetrics implements IMetricSet { + + private static final Logger LOGGER = LoggerFactory.getLogger(PipeEventCommitMetrics.class); + + private volatile AbstractMetricService metricService; + + private final Map<String, PipeEventCommitter> eventCommitterMap = new ConcurrentHashMap<>(); + + //////////////////////////// bindTo & unbindFrom (metric framework) //////////////////////////// + + @Override + public void bindTo(AbstractMetricService metricService) { + this.metricService = metricService; + ImmutableSet<String> committerKeys = ImmutableSet.copyOf(eventCommitterMap.keySet()); + for (String committerKey : committerKeys) { + createMetrics(committerKey); + } + } + + private void createMetrics(String committerKey) { + createAutoGauge(committerKey); + } + + private void createAutoGauge(String committerKey) { + PipeEventCommitter eventCommitter = eventCommitterMap.get(committerKey); + metricService.createAutoGauge( + Metric.PIPE_EVENT_COMMIT_QUEUE_SIZE.toString(), + MetricLevel.IMPORTANT, + eventCommitter, + PipeEventCommitter::commitQueueSize, + Tag.NAME.toString(), + String.valueOf(eventCommitter.getPipeName()), + Tag.REGION.toString(), + String.valueOf(eventCommitter.getDataRegionId())); + } + + @Override + public void unbindFrom(AbstractMetricService metricService) { + ImmutableSet<String> committerKeys = ImmutableSet.copyOf(eventCommitterMap.keySet()); + for (String committerKey : committerKeys) { + deregister(committerKey); + } + if (!eventCommitterMap.isEmpty()) { + LOGGER.warn("Failed to unbind from pipe event commit metrics, event committer map not empty"); + } + } + + private void removeMetrics(String committerKey) { + removeAutoGauge(committerKey); + } + + private void removeAutoGauge(String committerKey) { + PipeEventCommitter eventCommitter = eventCommitterMap.get(committerKey); + metricService.remove( + MetricType.AUTO_GAUGE, + Metric.PIPE_EVENT_COMMIT_QUEUE_SIZE.toString(), + Tag.NAME.toString(), + String.valueOf(eventCommitter.getPipeName()), + Tag.REGION.toString(), + String.valueOf(eventCommitter.getDataRegionId())); + } + + //////////////////////////// register & deregister (pipe integration) //////////////////////////// + + public void register(@NonNull PipeEventCommitter eventCommitter, String committerKey) { + eventCommitterMap.putIfAbsent(committerKey, eventCommitter); + if (Objects.nonNull(metricService)) { + createMetrics(committerKey); + } + } + + public void deregister(String committerKey) { + if (!eventCommitterMap.containsKey(committerKey)) { + LOGGER.warn( + "Failed to deregister pipe event commit metrics, PipeEventCommitter({}) does not exist", + committerKey); + return; + } + if (Objects.nonNull(committerKey)) { + removeMetrics(committerKey); + } + eventCommitterMap.remove(committerKey); + } + + //////////////////////////// singleton //////////////////////////// + + private static class PipeEventCommitMetricsHolder { + + private static final PipeEventCommitMetrics INSTANCE = new PipeEventCommitMetrics(); + + private PipeEventCommitMetricsHolder() { Review Comment: The private constructors for holders may be useless ########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/metric/PipeMetrics.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.confignode.manager.pipe.metric; + +import org.apache.iotdb.confignode.manager.pipe.PipeManager; +import org.apache.iotdb.metrics.AbstractMetricService; +import org.apache.iotdb.metrics.metricsets.IMetricSet; + +public class PipeMetrics implements IMetricSet { Review Comment: Better rename the original DN one to "PipeDataNodeMetrics" and this one to "PipeConfigNodeMetrics" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
