OneSizeFitsQuorum commented on code in PR #11614:
URL: https://github.com/apache/iotdb/pull/11614#discussion_r1404481110
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerMetrics.java:
##########
@@ -92,7 +92,7 @@ private void bindAutoGauge(AbstractMetricService
metricService) {
Metric.IOT_CONSENSUS.toString(),
MetricLevel.IMPORTANT,
impl,
- IoTConsensusServerImpl::getCurrentSafelyDeletedSearchIndex,
+ IoTConsensusServerImpl::getMinFlushedIndex,
Review Comment:
maybe we should monitor minSyncIndex or it will not be 0 even lag is 0
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerMetrics.java:
##########
@@ -92,7 +92,7 @@ private void bindAutoGauge(AbstractMetricService
metricService) {
Metric.IOT_CONSENSUS.toString(),
MetricLevel.IMPORTANT,
impl,
- IoTConsensusServerImpl::getCurrentSafelyDeletedSearchIndex,
+ IoTConsensusServerImpl::getMinFlushedIndex,
Review Comment:
maybe we should monitor minSyncIndex or it will not be 0 even actual lag is 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
