JackieTien97 commented on code in PR #11640:
URL: https://github.com/apache/iotdb/pull/11640#discussion_r1411521296
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java:
##########
@@ -2067,6 +2112,141 @@ private void deleteDataInFiles(
}
}
+ private void deleteDataDirectlyInFile(
+ List<TsFileResource> tsfileResourceList,
+ PartialPath pathToDelete,
+ long startTime,
+ long endTime)
+ throws IOException {
+ List<TsFileResource> deletedByMods = new ArrayList<>();
+ List<TsFileResource> deletedByFiles = new ArrayList<>();
+ separateTsFileToDelete(tsfileResourceList, deletedByMods, deletedByFiles,
startTime, endTime);
+ Deletion deletion = new Deletion(pathToDelete,
MERGE_MOD_START_VERSION_NUM, startTime, endTime);
+ // can be deleted by mods.
+ for (TsFileResource tsFileResource : deletedByMods) {
+ ModificationFile modFile = tsFileResource.getModFile();
+ if (tsFileResource.isClosed()) {
+ long originSize = -1;
+ synchronized (modFile) {
+ try {
+ originSize = modFile.getSize();
+ // delete data in sealed file
+ if (tsFileResource.isCompacting()) {
+ // we have to set modification offset to MAX_VALUE, as the
offset of source chunk
+ // may change after compaction
+ deletion.setFileOffset(Long.MAX_VALUE);
+ // write deletion into compaction modification file
+ tsFileResource.getCompactionModFile().write(deletion);
+ // write deletion into modification file to enable read during
compaction
+ modFile.write(deletion);
+ // remember to close mod file
+ tsFileResource.getCompactionModFile().close();
+ modFile.close();
+ } else {
+ deletion.setFileOffset(tsFileResource.getTsFileSize());
+ // write deletion into modification file
+ boolean modFileExists = modFile.exists();
+
+ modFile.write(deletion);
+
+ // remember to close mod file
+ modFile.close();
+
+ // if file length greater than 1M,execute compact.
+ modFile.compact();
+
+ if (!modFileExists) {
+ FileMetrics.getInstance().increaseModFileNum(1);
+ }
+
+ // The file size may be smaller than the original file, so the
increment here may be
+ // negative
+ FileMetrics.getInstance().increaseModFileSize(modFile.getSize()
- originSize);
+ }
+ } catch (Throwable t) {
+ if (originSize != -1) {
+ modFile.truncate(originSize);
+ }
+ throw t;
+ }
+ logger.info(
+ "[Deletion] Deletion with path:{}, time:{}-{} written into mods
file:{}.",
+ deletion.getPath(),
+ deletion.getStartTime(),
+ deletion.getEndTime(),
+ modFile.getFilePath());
+ }
+ } else {
+ // delete data in memory of unsealed file
+ tsFileResource
+ .getProcessor()
+ .deleteDataInMemory(deletion, new
HashSet<>(pathToDelete.getDevicePathPattern()));
+ }
+ }
+
+ // can be deleted by files
+ for (TsFileResource tsFileResource : deletedByFiles) {
+ if (!tsFileResource.isClosed()) {
+ tsFileResource
+ .getProcessor()
+ .deleteDataInMemory(deletion, new
HashSet<>(pathToDelete.getDevicePathPattern()));
+ tsFileResource.close();
+ }
+
+ tsFileResource.setStatus(TsFileResourceStatus.DELETED);
Review Comment:
You shouldn't ignore the return result of setStatus, because we cannot
directly delete tsfile while it's being compacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
