liyuheng55555 commented on code in PR #11663:
URL: https://github.com/apache/iotdb/pull/11663#discussion_r1416745219
##########
iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/persistence/PartitionInfoTest.java:
##########
@@ -80,16 +81,16 @@ public int getFlag() {
}
}
- @BeforeClass
- public static void setup() {
+ @Before
Review Comment:
I suggest to make sure this work.
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/DatabasePartitionTable.java:
##########
@@ -593,6 +594,12 @@ public List<Integer> getDataRegionIds() {
return dataRegionIds;
}
+ public Stream<TConsensusGroupType> getRegionType(int regionId) {
Review Comment:
I believe it will be better if return **List** instead of Stream (to keep
consistent with other method).
And, getRegionType**s**
##########
iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/persistence/PartitionInfoTest.java:
##########
@@ -187,43 +227,43 @@ public void testShowRegion() {
regionReq.setShowRegionReq(showRegionReq);
RegionInfoListResp regionInfoList1 =
(RegionInfoListResp) partitionInfo.getRegionInfoList(regionReq);
- Assert.assertEquals(regionInfoList1.getRegionInfoList().size(), 20);
+ Assert.assertEquals(20, regionInfoList1.getRegionInfoList().size());
Review Comment:
Learned !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
