SteveYurongSu commented on code in PR #11639: URL: https://github.com/apache/iotdb/pull/11639#discussion_r1420901115
########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtask.java: ########## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.confignode.manager.pipe.execution; + +import org.apache.iotdb.commons.pipe.execution.scheduler.PipeSubtaskScheduler; +import org.apache.iotdb.commons.pipe.plugin.builtin.connector.schema.IoTDBSchemaConnector; +import org.apache.iotdb.commons.pipe.plugin.builtin.extractor.schema.IoTDBSchemaExtractor; +import org.apache.iotdb.commons.pipe.task.DecoratingLock; +import org.apache.iotdb.commons.pipe.task.subtask.PipeSubtask; +import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameterValidator; +import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameters; +import org.apache.iotdb.pipe.api.event.Event; +import org.apache.iotdb.pipe.api.exception.PipeConnectionException; +import org.apache.iotdb.pipe.api.exception.PipeException; + +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.ListeningExecutorService; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Map; +import java.util.concurrent.ExecutorService; + +public class PipeConfigNodeSubtask extends PipeSubtask { + + private static final Logger LOGGER = LoggerFactory.getLogger(PipeConfigNodeSubtask.class); + + private final IoTDBSchemaExtractor inputPipeExtractor; + private final IoTDBSchemaConnector outputPipeConnector; Review Comment: 1. 建议还是可以保持三段式的定义，用抽象接口，而非具体的 IoTDBSchemaExtractor IoTDBSchemaConnector 2. 构造的时候建议跟 Data Region 一样，做一个 builder 和 constructor，以反射的方式构造他们 ########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtask.java: ########## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.confignode.manager.pipe.execution; + +import org.apache.iotdb.commons.pipe.execution.scheduler.PipeSubtaskScheduler; +import org.apache.iotdb.commons.pipe.plugin.builtin.connector.schema.IoTDBSchemaConnector; +import org.apache.iotdb.commons.pipe.plugin.builtin.extractor.schema.IoTDBSchemaExtractor; +import org.apache.iotdb.commons.pipe.task.DecoratingLock; +import org.apache.iotdb.commons.pipe.task.subtask.PipeSubtask; +import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameterValidator; +import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameters; +import org.apache.iotdb.pipe.api.event.Event; +import org.apache.iotdb.pipe.api.exception.PipeConnectionException; +import org.apache.iotdb.pipe.api.exception.PipeException; + +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.ListeningExecutorService; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Map; +import java.util.concurrent.ExecutorService; + +public class PipeConfigNodeSubtask extends PipeSubtask { + + private static final Logger LOGGER = LoggerFactory.getLogger(PipeConfigNodeSubtask.class); + + private final IoTDBSchemaExtractor inputPipeExtractor; + private final IoTDBSchemaConnector outputPipeConnector; Review Comment: 1. 建议还是可以保持三段式的定义，用抽象接口，而非具体的 IoTDBSchemaExtractor IoTDBSchemaConnector 2. 构造的时候建议跟 Data Region 一样，做一个 builder 和 constructor，以反射的方式构造他们 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
