OneSizeFitsQuorum commented on code in PR #11702:
URL: https://github.com/apache/iotdb/pull/11702#discussion_r1425105832
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java:
##########
@@ -236,6 +236,7 @@ public void notifyLeaderReady() {
configManager.checkUserPathPrivilege();
// Add Metric after leader ready
configManager.addMetrics();
+ configManager.getClusterManager().checkClusterId();
Review Comment:
async and add comment
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java:
##########
@@ -203,6 +204,8 @@ public class ConfigManager implements IManager {
private static final ConfigNodeConfig CONF =
ConfigNodeDescriptor.getInstance().getConf();
private static final CommonConfig COMMON_CONF =
CommonDescriptor.getInstance().getConfig();
+ private final ClusterManager clusterManager;
Review Comment:
move to line 212
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java:
##########
@@ -55,6 +55,7 @@ public IoTDBShutdownHook() {
@Override
public void run() {
+ logger.info("IoTDB exiting...");
Review Comment:
DataNode exiting
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java:
##########
@@ -272,6 +277,7 @@ public ConfigManager() throws IOException {
quotaInfo);
this.stateMachine = new ConfigRegionStateMachine(this, executor);
+ this.clusterManager = new ClusterManager(this, clusterInfo);
Review Comment:
move to line 283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
