JackieTien97 commented on code in PR #11671:
URL: https://github.com/apache/iotdb/pull/11671#discussion_r1420048752
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##########
@@ -1111,26 +1148,29 @@ private void unpackUnseqTsFileResource() throws
IOException {
}
protected ITimeSeriesMetadata loadTimeSeriesMetadata(
- TsFileResource resource,
- PartialPath seriesPath,
- QueryContext context,
- Filter filter,
- Set<String> allSensors)
- throws IOException {
+ TsFileResource resource, PartialPath seriesPath, QueryContext context)
throws IOException {
return FileLoaderUtils.loadTimeSeriesMetadata(
- resource, seriesPath, context, filter, allSensors);
+ resource,
+ seriesPath,
+ context,
+ scanOptions.getGlobalTimeFilter(),
+ scanOptions.getAllSensors());
}
- protected List<TSDataType> getTsDataTypeList() {
+ public List<TSDataType> getTsDataTypeList() {
return Collections.singletonList(dataType);
}
protected IPointReader getPointReader(TsBlock tsBlock) {
return tsBlock.getTsBlockSingleColumnIterator();
}
- Filter getGlobalTimeFilter() {
- return scanOptions.getGlobalTimeFilter();
+ protected boolean timeAllSelected(IMetadata metadata) {
+ return metadata.timeAllSelected();
Review Comment:
just return true? since AlignedSeriesScanUtil already override this method.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##########
@@ -1097,12 +1139,7 @@ private void unpackSeqTsFileResource() throws
IOException {
private void unpackUnseqTsFileResource() throws IOException {
ITimeSeriesMetadata timeseriesMetadata =
- loadTimeSeriesMetadata(
- orderUtils.getNextUnseqFileResource(true),
- seriesPath,
- context,
- getGlobalTimeFilter(),
- scanOptions.getAllSensors());
+ loadTimeSeriesMetadata(orderUtils.getNextUnseqFileResource(true),
seriesPath, context);
if (timeseriesMetadata != null) {
timeseriesMetadata.setModified(true);
Review Comment:
why here need to be set to modified?
##########
iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/block/TsBlock.java:
##########
@@ -223,6 +223,18 @@ public Column[] getColumns(int[] columnIndexes) {
return columns;
}
+ public Object[] getRowValues(int rowIndex) {
+ Object[] rowValues = new Object[valueColumns.length];
+ for (int i = 0; i < valueColumns.length; i++) {
+ if (valueColumns[i].isNull(rowIndex)) {
+ rowValues[i] = null;
+ } else {
+ rowValues[i] = valueColumns[i].getObject(rowIndex);
+ }
+ }
+ return rowValues;
+ }
+
Review Comment:
```suggestion
```
not used, can be removed.
##########
iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/filter/operator/Not.java:
##########
@@ -57,6 +58,11 @@ public boolean satisfyRow(long time, Object[] values) {
return !filter.satisfyRow(time, values);
}
+ @Override
+ public boolean[] satisfyTsBlock(TsBlock tsBlock) {
+ return filter.satisfyTsBlock(tsBlock);
Review Comment:
should add `!`
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/SeriesScanUtil.java:
##########
@@ -1192,8 +1221,8 @@ TsBlock getAllSatisfiedPageData(boolean ascending) throws
IOException {
}
}
- void setFilter(Filter filter) {
- data.setFilter(filter);
+ void setPushDownFilter(Filter pushDownFilter) {
Review Comment:
```suggestion
void addPushDownFilter(Filter pushDownFilter) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
