Beyyes commented on code in PR #11752:
URL: https://github.com/apache/iotdb/pull/11752#discussion_r1436268254
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/OperatorTreeGenerator.java:
##########
@@ -2535,7 +2588,7 @@ private List<TSDataType>
getOutputColumnTypesOfTimeJoinNode(PlanNode node) {
dataTypes.add(((SeriesScanNode)
child).getSeriesPath().getSeriesType());
} else if (child instanceof AlignedSeriesScanNode) {
dataTypes.add(((AlignedSeriesScanNode)
child).getAlignedPath().getSeriesType());
- } else if (child instanceof TimeJoinNode) {
+ } else if (child instanceof FullOuterTimeJoinNode) {
Review Comment:
Maybe we need change to `child instanceof FullOuterTimeJoinNode or child
instanceof LeftOuterTimeJoinNode or child instanceof InnerTimeJoinNode`.
I will test template + align by device query when the function is completed
later.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java:
##########
@@ -693,7 +696,7 @@ public List<PlanNode> visitTimeJoin(TimeJoinNode node,
DistributionPlanContext c
return Collections.singletonList(processRawMultiChildNode(node, context,
true));
}
- // Only `visitTimeJoin` and `visitLastQuery` invoke this method
+ // Only `visitFullOuterTimeJoin` and `visitLastQuery` invoke this method
Review Comment:
Maybe `visitLeftOuterTimeJoin` and `visitInnerTimeJoin` can also invoke this
method. I will check this logic later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
