Caideyipi commented on code in PR #12018:
URL: https://github.com/apache/iotdb/pull/12018#discussion_r1477180552


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java:
##########
@@ -1663,10 +1663,12 @@ public SettableFuture<ConfigTaskResult> 
alterPipe(AlterPipeStatement alterPipeSt
 
     // Validate before alteration
     try {
-      if (!alterPipeStatement.getProcessorAttributes().isEmpty()) {
+      if (!alterPipeStatement.getProcessorAttributes().isEmpty()
+          && alterPipeStatement.isReplaceAllProcessorAttributes()) {
         
PipeAgent.plugin().validateProcessor(alterPipeStatement.getProcessorAttributes());

Review Comment:
   I think it's better to try validate the "modify" as well if the pipeMeta 
persists in the PipeTaskMeta. If not, you can do nothing here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to