Caideyipi commented on code in PR #12085:
URL: https://github.com/apache/iotdb/pull/12085#discussion_r1507333694
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/task/CreatePipeProcedureV2.java:
##########
@@ -67,6 +68,16 @@ public CreatePipeProcedureV2() {
public CreatePipeProcedureV2(TCreatePipeReq createPipeRequest) throws
PipeException {
super();
this.createPipeRequest = createPipeRequest;
+ // For newly created pipes, we add an internal "source.version" attribute
to identify them.
+ // Pipes without this attribute will be treated as legacy version, and
their default pattern
+ // format will be "prefix".
+ // Pipes with this attribute will be treated as new version, and their
default pattern format
+ // will be "iotdb".
+ this.createPipeRequest
+ .getExtractorAttributes()
+ .put(
+ PipeExtractorConstant.SOURCE_VERSION_KEY,
Review Comment:
> After MQ discussion, it is decided that only "IOTDB" format is exposed to
users. Thus, it's better use "extractor.path" to identify the "IOTDB" and
"extractor.pattern" to identify the "prefix". There is no longer "format" and
this naturally supports capatibility.
The document can be updated too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
