OneSizeFitsQuorum commented on code in PR #12050:
URL: https://github.com/apache/iotdb/pull/12050#discussion_r1525809114
##########
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcTransportFactory.java:
##########
@@ -19,105 +19,28 @@
package org.apache.iotdb.rpc;
-import org.apache.thrift.transport.TMemoryInputTransport;
-import org.apache.thrift.transport.TSSLTransportFactory;
-import org.apache.thrift.transport.TSocket;
-import org.apache.thrift.transport.TTransport;
-import org.apache.thrift.transport.TTransportException;
import org.apache.thrift.transport.TTransportFactory;
-@SuppressWarnings("java:S1135") // ignore todos
-public class RpcTransportFactory extends TTransportFactory {
+public class RpcTransportFactory extends BaseRpcTransportFactory {
Review Comment:
ZeroCopyRpcTransportFactory
##########
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/TimeoutChangeableTFastFramedTransport.java:
##########
@@ -56,19 +56,22 @@ public static class Factory extends TTransportFactory {
private final int thriftDefaultBufferSize;
protected final int thriftMaxFrameSize;
+ protected final boolean copyBinary;
- public Factory(int thriftDefaultBufferSize, int thriftMaxFrameSize) {
+ public Factory(int thriftDefaultBufferSize, int thriftMaxFrameSize,
boolean copyBinary) {
this.thriftDefaultBufferSize = thriftDefaultBufferSize;
this.thriftMaxFrameSize = thriftMaxFrameSize;
+ this.copyBinary = copyBinary;
}
@Override
public TTransport getTransport(TTransport trans) {
if (trans instanceof TSocket) {
return new TimeoutChangeableTFastFramedTransport(
- (TSocket) trans, thriftDefaultBufferSize, thriftMaxFrameSize);
+ (TSocket) trans, thriftDefaultBufferSize, thriftMaxFrameSize,
copyBinary);
} else {
- return new TElasticFramedTransport(trans, thriftDefaultBufferSize,
thriftMaxFrameSize);
+ return new TElasticFramedTransport(
Review Comment:
copyBinary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
