OneSizeFitsQuorum commented on code in PR #12202:
URL: https://github.com/apache/iotdb/pull/12202#discussion_r1533625247
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/ProcedureInfo.java:
##########
@@ -105,23 +107,29 @@ public List<Procedure<ConfigNodeProcedureEnv>> oldLoad() {
}
procedureList.forEach(procedure -> procedureMap.put(procedure.getProcId(),
procedure));
procedureList.forEach(procedure -> lastProcId = Math.max(lastProcId,
procedure.getProcId()));
- try {
- LOGGER.info("Old procedure files have been loaded successfully, taking
snapshot...");
- configManager.getConsensusManager().manuallyTakeSnapshot();
- } catch (ConsensusException e) {
- LOGGER.warn("Taking snapshot fail, upgrade fail", e);
- return procedureList;
- }
- try {
- FileUtils.recursiveDeleteFolder(OLD_PROCEDURE_WAL_DIR);
- } catch (IOException e) {
- LOGGER.error("Delete useless procedure wal dir fail.", e);
- LOGGER.error(
- "You should manually delete the procedure wal dir before ConfigNode
restart. {}",
- OLD_PROCEDURE_WAL_DIR);
- }
- LOGGER.info(
- "The Procedure framework has been successfully upgraded. Now it uses
the consensus layer's services instead of maintaining the WAL itself.");
+ ExecutorService executorService =
Review Comment:
use ConfigRegionStateMachine.threadPool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
