OneSizeFitsQuorum commented on code in PR #12232:
URL: https://github.com/apache/iotdb/pull/12232#discussion_r1537353159
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/service/HeartbeatService.java:
##########
@@ -150,6 +153,17 @@ private TDataNodeHeartbeatReq genHeartbeatReq() {
return heartbeatReq;
}
+ private void addConfigNodeLocationsToReq(int dataNodeId,
TDataNodeHeartbeatReq req) {
+ Set<TConfigNodeLocation> confirmedConfigNodes =
+ loadCache.getConfirmedConfigNodeLocations(dataNodeId);
+ Set<TConfigNodeLocation> actualConfigNodes =
+ new HashSet<>(getNodeManager().getRegisteredConfigNodes());
+ if (!actualConfigNodes.equals(confirmedConfigNodes)
Review Comment:
always carry this list?
##########
iotdb-protocol/thrift-datanode/src/main/thrift/datanode.thrift:
##########
@@ -252,6 +252,7 @@ struct TDataNodeHeartbeatReq {
8: optional bool needPipeMetaList
9: optional i64 deviceQuotaRemain
10: optional TDataNodeActivation activation
+ 11: optional set<common.TConfigNodeLocation> configNodeLocations
Review Comment:
use id is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
