SteveYurongSu commented on code in PR #12217: URL: https://github.com/apache/iotdb/pull/12217#discussion_r1538850313
########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/subscription/topic/runtime/TopicMetaSyncProcedure.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.confignode.procedure.impl.subscription.topic.runtime; + +import org.apache.iotdb.common.rpc.thrift.TSStatus; +import org.apache.iotdb.commons.pipe.config.PipeConfig; +import org.apache.iotdb.commons.subscription.meta.topic.TopicMeta; +import org.apache.iotdb.confignode.consensus.request.write.subscription.topic.runtime.TopicHandleMetaChangePlan; +import org.apache.iotdb.confignode.procedure.env.ConfigNodeProcedureEnv; +import org.apache.iotdb.confignode.procedure.impl.subscription.AbstractOperateSubscriptionProcedure; +import org.apache.iotdb.confignode.procedure.impl.subscription.SubscriptionOperation; +import org.apache.iotdb.confignode.procedure.state.ProcedureLockState; +import org.apache.iotdb.confignode.procedure.store.ProcedureType; +import org.apache.iotdb.consensus.exception.ConsensusException; +import org.apache.iotdb.mpp.rpc.thrift.TPushTopicMetaResp; +import org.apache.iotdb.pipe.api.exception.PipeException; +import org.apache.iotdb.rpc.TSStatusCode; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.DataOutputStream; +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.atomic.AtomicLong; + +public class TopicMetaSyncProcedure extends AbstractOperateSubscriptionProcedure { + + private static final Logger LOGGER = LoggerFactory.getLogger(TopicMetaSyncProcedure.class); + + private static final long MIN_EXECUTION_INTERVAL_MS = + PipeConfig.getInstance().getPipeMetaSyncerSyncIntervalMinutes() * 60 * 1000 / 2; + // No need to serialize this field + private static final AtomicLong LAST_EXECUTION_TIME = new AtomicLong(0); + + public TopicMetaSyncProcedure() { + super(); + } + + @Override + protected ProcedureLockState acquireLock(ConfigNodeProcedureEnv configNodeProcedureEnv) { + // Skip the procedure if the last execution time is within the minimum execution interval. + // Often used to prevent the procedure from being executed too frequently when system reboot. + if (System.currentTimeMillis() - LAST_EXECUTION_TIME.get() < MIN_EXECUTION_INTERVAL_MS) { + // Skip by setting the subscriptionInfo to null + subscriptionInfo = null; + LOGGER.info( + "TopicMetaSyncProcedure: acquireLock, skip the procedure due to the last execution time {}", + LAST_EXECUTION_TIME.get()); + return ProcedureLockState.LOCK_ACQUIRED; + } + + return super.acquireLock(configNodeProcedureEnv); + } + + @Override + protected SubscriptionOperation getOperation() { + return SubscriptionOperation.SYNC_TOPIC_META; + } + + @Override + public void executeFromValidate(ConfigNodeProcedureEnv env) { + LOGGER.info("TopicMetaSyncProcedure: executeFromValidate"); + + LAST_EXECUTION_TIME.set(System.currentTimeMillis()); + } + + @Override + public void executeFromOperateOnConfigNodes(ConfigNodeProcedureEnv env) { + LOGGER.info("TopicMetaSyncProcedure: executeFromOperateOnConfigNodes"); + + final List<TopicMeta> topicMetaList = new ArrayList<>(); + subscriptionInfo.get().getAllTopicMeta().forEach(topicMetaList::add); + + TSStatus response; + try { + response = + env.getConfigManager() + .getConsensusManager() + .write(new TopicHandleMetaChangePlan(topicMetaList)); + } catch (ConsensusException e) { + LOGGER.warn("Failed in the write API executing the consensus layer due to: ", e); + response = new TSStatus(TSStatusCode.EXECUTE_STATEMENT_ERROR.getStatusCode()); + response.setMessage(e.getMessage()); + } + if (response.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) { + throw new PipeException(response.getMessage()); + } + } + + @Override + public void executeFromOperateOnDataNodes(ConfigNodeProcedureEnv env) throws IOException { + LOGGER.info("TopicMetaSyncProcedure: executeFromOperateOnDataNodes"); + + Map<Integer, TPushTopicMetaResp> respMap = pushTopicMetaToDataNodes(env); + if (pushTopicMetaHasException(respMap)) { + throw new PipeException( Review Comment: ```suggestion throw new SubscriptionException( ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
