Re: [PR] Subscription: initialize the subscription session and consumer & Pipe: fix data points loss caused by unclosed tsfile listened by histrorical extractor [iotdb]

[via GitHub]

Caideyipi commented on code in PR #12228:
URL: https://github.com/apache/iotdb/pull/12228#discussion_r1542252952


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SerializedEnrichedEvent.java:
##########
@@ -111,4 +111,21 @@ public boolean pollable() {
     return System.currentTimeMillis() - lastPolledTimestamp
         > 
SubscriptionConfig.getInstance().getSubscriptionRecycleUncommittedEventIntervalSeconds();
   }
+
+  @Override
+  public boolean equals(Object obj) {

Review Comment:
   What about hash code? Is the "enrichedTablets" enough in "equals"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org