THUMarkLau commented on code in PR #12113:
URL: https://github.com/apache/iotdb/pull/12113#discussion_r1544015731
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java:
##########
@@ -2744,6 +2780,209 @@ private void updateTSInsertTabletsReq(
request.addToSizeList(tablet.rowSize);
}
+ // sample some records and judge weather need to add too many null values to
convert to tablet.
+ public boolean judgeConvertOfOneDevice(List<List<String>> measurementsList) {
+ int size = measurementsList.size();
+ int sampleNum = (int) (size * SAMPLE_PROPORTION);
+ if (sampleNum < MIN_SAMPLE_SIZE) {
Review Comment:
should be MIN_RECORDS_NUM，comparing with the original size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
