OneSizeFitsQuorum commented on code in PR #12183:
URL: https://github.com/apache/iotdb/pull/12183#discussion_r1544050166
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java:
##########
@@ -785,6 +802,25 @@ public int getRegionGroupCount(String database,
TConsensusGroupType type)
return databasePartitionTables.get(database).getRegionGroupCount(type);
}
+ /**
+ * Only leader use this interface.
+ *
+ * <p>Get the all RegionGroups currently in the cluster
+ *
+ * @param type SchemaRegion or DataRegion
+ * @return Map<Database, List<RegionGroupIds>>
+ */
+ public Map<String, List<TConsensusGroupId>>
getAllRegionGroupIdMap(TConsensusGroupType type) {
+ Map<String, List<TConsensusGroupId>> result = new TreeMap<>();
+ databasePartitionTables.forEach(
+ (database, databasePartitionTable) -> {
+ if (databasePartitionTable.isNotPreDeleted()) {
Review Comment:
do we need to consider this field for getAllReplicaSets
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java:
##########
@@ -691,6 +692,22 @@ public List<TRegionReplicaSet> getAllReplicaSets(String
database) {
}
}
+ /**
+ * Only leader use this interface.
+ *
+ * @param database The specified Database
+ * @param type SchemaRegion or DataRegion
+ * @return Deep copy of all Regions' RegionReplicaSet with the specified
Database and
+ * TConsensusGroupType
+ */
+ public List<TRegionReplicaSet> getAllReplicaSets(String database,
TConsensusGroupType type) {
+ if (databasePartitionTables.containsKey(database)) {
+ return databasePartitionTables.get(database).getAllReplicaSets(type);
+ } else {
+ return new ArrayList<>();
Review Comment:
Collection.emptyList()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
