VGalaxies commented on code in PR #12294:
URL: https://github.com/apache/iotdb/pull/12294#discussion_r1564742733
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionConsumer.java:
##########
@@ -174,7 +179,7 @@ public synchronized void close() throws
IoTDBConnectionException {
shutdownEndpointsSyncer();
// shutdown heartbeat worker
Review Comment:
Correspondingly modify the comments.
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionPushConsumer.java:
##########
@@ -19,17 +19,167 @@
package org.apache.iotdb.session.subscription;
+import org.apache.iotdb.rpc.IoTDBConnectionException;
+import org.apache.iotdb.rpc.StatementExecutionException;
+import org.apache.iotdb.rpc.subscription.config.ConsumerConstant;
import org.apache.iotdb.rpc.subscription.exception.SubscriptionException;
+import org.apache.thrift.TException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Properties;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
// TODO
Review Comment:
remove TODO?
##########
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/subscription/config/ConsumerConstant.java:
##########
@@ -53,7 +53,11 @@ public class ConsumerConstant {
/////////////////////////////// push consumer ///////////////////////////////
- // TODO
+ public static final String ACK_STRATEGY_KEY = "ack-strategy";
+
+ // TODO: configure this parameter
+ public static final int PUSH_CONSUMER_AUTO_POLL_INTERVAL = 1000;
+ public static final int PUSH_CONSUMER_AUTO_POLL_TIME_OUT = 2000;
Review Comment:
It's better to add time units in the naming like `_MS_`.
##########
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/subscription/config/ConsumerConstant.java:
##########
@@ -53,7 +53,11 @@ public class ConsumerConstant {
/////////////////////////////// push consumer ///////////////////////////////
- // TODO
+ public static final String ACK_STRATEGY_KEY = "ack-strategy";
+
Review Comment:
Need to support specifying ConsumeListener in the property-style constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
