shuwenwei commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1565341065
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.storageengine.dataregion.compaction.io; + +import org.apache.iotdb.db.conf.IoTDBDescriptor; +import org.apache.iotdb.db.storageengine.dataregion.compaction.schedule.CompactionTaskManager; +import org.apache.iotdb.tsfile.write.writer.TsFileOutput; + +import com.google.common.util.concurrent.RateLimiter; + +import java.io.IOException; +import java.io.OutputStream; +import java.nio.ByteBuffer; + +public class CompactionTsFileOutput extends OutputStream implements TsFileOutput { + + private TsFileOutput output; + private RateLimiter rateLimiter = CompactionTaskManager.getInstance().getMergeWriteRateLimiter(); + private final long maxSizePerWrite; + + public CompactionTsFileOutput(TsFileOutput output) { + this.output = output; + maxSizePerWrite = + (int) + (rateLimiter.getRate() + / IoTDBDescriptor.getInstance().getConfig().getCompactionThreadCount()); Review Comment: The write will obtain write size twice, but it won't wait because the rate is 40MB/s. This parameter intends to avoid large write blocks small write: If a thread acquired large write size in one time, other threads may be blocked for a while. However, it may split a write to many part and i'm not sure what the impact is. Another implementation I thought is to remove `/ IoTDBDescriptor.getInstance().getConfig().getCompactionThreadCount()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
