Caideyipi commented on code in PR #12344:
URL: https://github.com/apache/iotdb/pull/12344#discussion_r1570208783
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/event/EnrichedEvent.java:
##########
@@ -148,6 +152,9 @@ public boolean decreaseReferenceCount(String holderMessage,
boolean shouldReport
Thread.currentThread().getStackTrace());
}
}
+ if (!isSuccessful) {
Review Comment:
It seems that the flag is meaningless and the "0" reference count will still
go "<0" and succeed.
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/PipeReceiverStatusHandler.java:
##########
@@ -133,12 +133,14 @@ public void handle(TSStatus status, String
exceptionMessage, String recordMessag
LOGGER.warn(
"User conflict exception: will retry {}. status: {}",
- (retryMaxMillisWhenConflictOccurs == Long.MAX_VALUE ? "forever"
: "for at least ")
- + (retryMaxMillisWhenConflictOccurs
- + exceptionFirstEncounteredTime.get()
- - System.currentTimeMillis())
- / 1000.0
- + " seconds",
+ retryMaxMillisWhenConflictOccurs == Long.MAX_VALUE
Review Comment:
Personally I think keeping the "()" is clearer...
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataRegionSyncConnector.java:
##########
@@ -182,6 +224,8 @@ private void doTransfer() {
tabletBatchBuilder.deepCopyEvents().toString());
}
+ tabletBatchBuilder.decreaseEventsReferenceCount(
+ IoTDBDataRegionSyncConnector.class.getName(), false);
Review Comment:
Why false here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
