HTHou commented on code in PR #12368:
URL: https://github.com/apache/iotdb/pull/12368#discussion_r1570310335
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/AddRegionPeerProcedure.java:
##########
@@ -132,31 +143,39 @@ protected Flow executeFromState(ConfigNodeProcedureEnv
env, AddRegionPeerState s
case UPDATE_REGION_LOCATION_CACHE:
handler.updateRegionCache(consensusGroupId, destDataNode,
RegionStatus.Running);
setKillPoint(state);
- LOGGER.info("AddRegionPeer state {} complete", state);
+ LOGGER.info("[pid{}][AddRegion] state {} complete", getProcId(),
state);
LOGGER.info(
- "AddRegionPeerProcedure success, region {} has been added to
DataNode {}",
+ "[pid{}][AddRegion] success, region {} has been added to
DataNode {}. Procedure took {} (start at {}).",
+ getProcId(),
consensusGroupId.getId(),
- destDataNode.getDataNodeId());
+ destDataNode.getDataNodeId(),
+ CommonDateTimeUtils.convertMillisecondToDurationStr(
+ System.currentTimeMillis() - getSubmittedTime()),
+ DateTimeUtils.convertLongToDate(getSubmittedTime()));
Review Comment:
Using `DateTimeUtils.convertLongToDate(long timestamp, String
sourcePrecision)` instead?
`DateTimeUtils.convertLongToDate(long timestamp)` will use `ns` as the
precision when timestamp_precision is `ns`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
