Caideyipi commented on code in PR #12356: URL: https://github.com/apache/iotdb/pull/12356#discussion_r1590841482
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileRateLimiter.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.load; + +import org.apache.iotdb.db.conf.IoTDBConfig; +import org.apache.iotdb.db.conf.IoTDBDescriptor; + +import com.google.common.util.concurrent.RateLimiter; + +public class LoadTsFileRateLimiter { + + private static final IoTDBConfig CONFIG = IoTDBDescriptor.getInstance().getConfig(); + + private RateLimiter loadWriteRateLimiter; + + private double throughoutMbPerSec = CONFIG.getLoadWriteThroughputMbPerSecond(); Review Comment: Does it mean "throughput"? ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileRateLimiter.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.load; + +import org.apache.iotdb.db.conf.IoTDBConfig; +import org.apache.iotdb.db.conf.IoTDBDescriptor; + +import com.google.common.util.concurrent.RateLimiter; + +public class LoadTsFileRateLimiter { + + private static final IoTDBConfig CONFIG = IoTDBDescriptor.getInstance().getConfig(); + + private RateLimiter loadWriteRateLimiter; + + private double throughoutMbPerSec = CONFIG.getLoadWriteThroughputMbPerSecond(); + + public LoadTsFileRateLimiter() { + loadWriteRateLimiter = RateLimiter.create(throughoutMbPerSec); + } + + private void setWritePointRate(final double throughoutMbPerSec) { + double throughout = throughoutMbPerSec * 1024.0 * 1024.0; + // if throughout = 0, disable rate limiting + if (throughout <= 0) { + throughout = Double.MAX_VALUE; Review Comment: ...... ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/load/LoadTsFileScheduler.java: ########## @@ -141,6 +143,7 @@ public LoadTsFileScheduler( this.allReplicaSets = new HashSet<>(); this.isGeneratedByPipe = isGeneratedByPipe; this.block = LoadTsFileMemoryManager.getInstance().allocateDataCacheMemoryBlock(); + this.loadTsFileRateLimiter = new LoadTsFileRateLimiter(); Review Comment: Make the limiter private per scheduler may not be of use because the scheduler is created per statement. It is maybe ideal to make a public static one in loadTsFileManager and use that. ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileRateLimiter.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.load; + +import org.apache.iotdb.db.conf.IoTDBConfig; +import org.apache.iotdb.db.conf.IoTDBDescriptor; + +import com.google.common.util.concurrent.RateLimiter; + +public class LoadTsFileRateLimiter { + + private static final IoTDBConfig CONFIG = IoTDBDescriptor.getInstance().getConfig(); + + private RateLimiter loadWriteRateLimiter; + + private double throughoutMbPerSec = CONFIG.getLoadWriteThroughputMbPerSecond(); Review Comment: Besides, for the limiter may be accessed concurrently I suggest you use atomicDouble instead. The RateLimiter is checked and won't have any concurrency problems. ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileManager.java: ########## @@ -80,6 +80,8 @@ public class LoadTsFileManager { private final Map<String, CleanupTask> uuid2CleanupTask = new ConcurrentHashMap<>(); private final PriorityBlockingQueue<CleanupTask> cleanupTaskQueue = new PriorityBlockingQueue<>(); + private static final LoadTsFileRateLimiter loadTsFileRateLimiter = new LoadTsFileRateLimiter(); Review Comment: If it is a static one I suggest using upper case as variable name instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
