Cpaulyz commented on PR #12477: URL: https://github.com/apache/iotdb/pull/12477#issuecomment-2122357167
> Hi, there are some code in TsFileProcessor I think need to be considered. > > https://github.com/apache/iotdb/blob/b0306420a1079f47a6743087773ba1ae4517d610/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java#L592 @HTHou Thanks for the reminder! I missed some checks on TEXT. I made some changes in commit 228bba7515. Please help review them for me~ I think adding an isBinary() method to TSDataType would have been a better choice, but that would have required to modify the TsFile repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
