SteveYurongSu commented on code in PR #12578:
URL: https://github.com/apache/iotdb/pull/12578#discussion_r1615457322
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipeInfo.java:
##########
@@ -130,48 +136,61 @@ public TSStatus dropPipe(DropPipePlanV2 plan) {
try {
PipeConfigNodeAgent.runtime()
.decreaseListenerReference(meta.getStaticMeta().getExtractorParameters());
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new PipeException("Failed to decrease listener
reference", e);
}
});
+ PipeTemporaryMetaMetrics.getInstance()
+ .handleTemporaryMetaChanges(pipeTaskInfo.getPipeMetaList());
return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
} else {
return new TSStatus(TSStatusCode.PIPE_ERROR.getStatusCode())
.setMessage(message.getMessage());
}
- } catch (Exception e) {
+ } catch (final Exception e) {
LOGGER.error("Failed to drop pipe", e);
return new TSStatus(TSStatusCode.PIPE_ERROR.getStatusCode())
.setMessage("Failed to drop pipe, because " + e.getMessage());
}
}
- public TSStatus alterPipe(AlterPipePlanV2 plan) {
+ public TSStatus alterPipe(final AlterPipePlanV2 plan) {
try {
pipeTaskInfo.alterPipe(plan);
PipeConfigNodeAgent.task()
.handleSinglePipeMetaChanges(
pipeTaskInfo.getPipeMetaByPipeName(plan.getPipeStaticMeta().getPipeName()));
return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
- } catch (Exception e) {
+ } catch (final Exception e) {
LOGGER.error("Failed to alter pipe", e);
return new TSStatus(TSStatusCode.PIPE_ERROR.getStatusCode())
.setMessage("Failed to alter pipe, because " + e.getMessage());
}
}
- public TSStatus operateMultiplePipes(OperateMultiplePipesPlanV2 plans) {
+ /**
+ * Note: This interface is only used for subscription and thus irrelevant to
the {@link
+ * PipeConfigNodeSubtask}. Hence, we can skip the operation of {@link
PipeConfigNodeTaskAgent} and
+ * {@link PipeConfigRegionListener} here.
+ *
+ * @param plans An {@link OperateMultiplePipesPlanV2} consisting of many
subPlans
+ * @return result {@link TSStatus}
+ */
+ public TSStatus operateMultiplePipes(final OperateMultiplePipesPlanV2 plans)
{
Review Comment:
@SteveYurongSu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
