JackieTien97 commented on code in PR #12550:
URL: https://github.com/apache/iotdb/pull/12550#discussion_r1616527976
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java:
##########
@@ -1556,12 +1556,14 @@ private void calculateGroupByLevelNodeAttributes(
descriptorExpressions.addAll(originalDescriptor.getOutputExpressions());
}
- for (String groupedInputExpressionString :
- originalDescriptor.getGroupedInputExpressionStrings()) {
+ for (List<Expression> groupedInputExpressions :
+ originalDescriptor.getGroupedInputExpressions()) {
+ String groupedInputExpressionsString =
+ originalDescriptor.getInputString(groupedInputExpressions);
List<Expression> inputExpressions =
- childrenExpressionMap.get(groupedInputExpressionString);
+ childrenExpressionMap.get(groupedInputExpressionsString);
if (inputExpressions != null && !inputExpressions.isEmpty()) {
- descriptorExpressions.addAll(inputExpressions);
+ descriptorExpressions.addAll(groupedInputExpressions);
}
}
Review Comment:
use a field to indicate that there exists view, otherwise we keep same as
previous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
