OneSizeFitsQuorum commented on code in PR #12459:
URL: https://github.com/apache/iotdb/pull/12459#discussion_r1618114191
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileManager.java:
##########
@@ -353,6 +353,7 @@ private void loadAll(boolean isGeneratedByPipe,
ProgressIndex progressIndex)
MemTableFlushTask.recordFlushPointsMetricInternal(
writePointCount, databaseName,
dataRegion.getDataRegionId());
+ // TODO @SpriCoder check how load use consensus
Review Comment:
For load, since it bypasses the consensus layer, we don't count it from
memtable, we can just count it from scheduler?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNode.java:
##########
@@ -49,6 +49,7 @@ public abstract class PlanNode implements IConsensusRequest {
protected PlanNodeId id;
protected boolean isGeneratedByPipe = false;
+ protected boolean isGeneratedByRemote = false;
Review Comment:
isGeneratedByRemoteConsensusLeader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
