OneSizeFitsQuorum commented on code in PR #12643:
URL: https://github.com/apache/iotdb/pull/12643#discussion_r1625739482
##########
iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ImportSchema.java:
##########
@@ -124,12 +122,12 @@ private static Options createOptions() {
.build();
options.addOption(opFailedFile);
- Option opAligned =
- Option.builder(ALIGNED_ARGS)
- .longOpt(ALIGNED_ARGS)
- .desc("Whether import schema as aligned timeseries(optional)")
- .build();
- options.addOption(opAligned);
+ // Option opAligned =
Review Comment:
just remove? do not comment code
##########
iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ImportSchema.java:
##########
@@ -103,7 +103,6 @@ private static Options createOptions() {
Option opFile =
Option.builder(FILE_ARGS)
- .required()
Review Comment:
seems line 110 still contains required
##########
iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ExportSchema.java:
##########
@@ -201,7 +201,6 @@ private static Options createOptions() {
Option opTargetFile =
Option.builder(TARGET_DIR_ARGS)
- .required()
Review Comment:
seems line 207 still contains "required"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
