ycycse commented on PR #12601: URL: https://github.com/apache/iotdb/pull/12601#issuecomment-2151595564
> I find the version requirement in requirement.txt is `# Pandas Export pandas>=1.3.5` Should we unify these? By the way, other requirements in requirement.txt are `# Pandas Export pandas>=1.3.5 numpy>=1.21.4 thrift>=0.14.1 # SQLAlchemy Dialect sqlalchemy == 1.3.20 sqlalchemy-utils == 0.36.8` which are not the same as the requirement in setup.py. Generally speaking, the version in `setup.py` determines the specific version of dependencies that users will download when installing our package. The requirements.txt is typically the version that developers pay attention to. Although inconsistency will not affect usage, in order to unify the development and application environment, I think it is better to unify the two (or let requirements.txt include what setup specifies). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
