JackieTien97 commented on code in PR #12700:
URL: https://github.com/apache/iotdb/pull/12700#discussion_r1637751994
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java:
##########
@@ -342,16 +342,18 @@ private void getStorageGroupMap(
* @param userName
*/
private void getStorageGroupCacheResult(
- StorageGroupCacheResult<?> result,
- List<String> devicePaths,
+ StorageGroupCacheResult<?, ?> result,
+ List<IDeviceID> devicePaths,
Review Comment:
fuzzy match shouldn't use `IDeviceID`
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PathPatternTree.java:
##########
@@ -169,11 +172,12 @@ public boolean isEmpty() {
&& (pathPatternList == null || pathPatternList.isEmpty());
}
- public List<String> getAllDevicePatterns() {
+ public List<IDeviceID> getAllDevicePatterns() {
Review Comment:
need to talk about it, if we are sure that we need IDeviceId, we should use
the way `List<PartialPath> getAllDevicePaths()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
