Caideyipi commented on code in PR #13176:
URL: https://github.com/apache/iotdb/pull/13176#discussion_r1717799169
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/connector/protocol/IoTDBConfigRegionConnector.java:
##########
@@ -63,14 +63,16 @@ protected IoTDBSyncClientManager constructClient(
final String trustStorePwd,
final boolean useLeaderCache,
final String loadBalanceStrategy,
- final boolean shouldReceiverConvertOnTypeMismatch) {
+ final boolean shouldReceiverConvertOnTypeMismatch,
+ final String loadTsFileStrategy) {
return new IoTDBConfigNodeSyncClientManager(
nodeUrls,
useSSL,
trustStorePath,
trustStorePwd,
loadBalanceStrategy,
- shouldReceiverConvertOnTypeMismatch);
+ shouldReceiverConvertOnTypeMismatch,
+ loadTsFileStrategy);
Review Comment:
Can pass "sync" here, users may use "async-load" in "inclusion=all", then
the configConnector will pass the "async-load" to receiver.... And it'll cause
problem when handling the snapshot.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataNodeSyncConnector.java:
##########
@@ -96,7 +97,8 @@ protected IoTDBSyncClientManager constructClient(
trustStorePwd,
useLeaderCache,
loadBalanceStrategy,
- shouldReceiverConvertOnTypeMismatch);
+ shouldReceiverConvertOnTypeMismatch,
+ loadTsFileStrategy);
Review Comment:
Consider the "schemaRegionConnector" instance, the non-dataRegion connectors
shall not pass "async-load"
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/receiver/IoTDBFileReceiver.java:
##########
@@ -451,6 +461,11 @@ protected final TPipeTransferResp
handleTransferFileSealV1(final PipeTransferFil
// writingFile will be deleted after load if no exception occurs
writingFile = null;
+ if (Objects.equals(
+ PipeConnectorConstant.CONNECTOR_LOAD_TSFILE_STRATEGY_ASYNC_VALUE,
loadTsFileStrategy)) {
+ return new TPipeTransferResp(asyncLoadTsFile(fileAbsolutePath));
Review Comment:
Consider the "fileSealV2"? That is used to handle tsFile with mods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
