133tosakarin commented on code in PR #13178:
URL: https://github.com/apache/iotdb/pull/13178#discussion_r1719618935
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/RatisClient.java:
##########
@@ -212,46 +218,39 @@ public Action handleAttemptFailure(Event event) {
}
// This policy is used to raft configuration change
+ //
private static class RatisEndlessRetryPolicy implements RetryPolicy {
private static final Logger logger =
LoggerFactory.getLogger(RatisEndlessRetryPolicy.class);
- private static final RetryPolicy defaultPolicy;
-
- static {
- String str = "";
- // 50, 500ms, 40, 1000ms, 30, 1500ms, 20, 2000ms, 10, 2500ms
- int basicRetry = 50;
- int basicSleep = 500;
- for (int i = 0; i < 5; i++) {
- str += basicRetry + "," + basicSleep + ",";
- basicRetry -= 10;
- basicSleep += 500;
- }
+ private final RetryPolicy defaultPolicy;
+ RatisEndlessRetryPolicy() {
+ // about 1 hour wait Time.
defaultPolicy =
- MultipleLinearRandomRetry.parseCommaSeparated(str.substring(0,
str.length() - 1));
+ RetryPolicies.retryForeverWithSleep(TimeDuration.valueOf(2,
TimeUnit.SECONDS));
}
Review Comment:
1. if reply return false, then resend request after 2s. Instead of sending
it every 2 seconds
sorry, I forget delete comment
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/RatisClient.java:
##########
@@ -212,46 +218,39 @@ public Action handleAttemptFailure(Event event) {
}
// This policy is used to raft configuration change
+ //
private static class RatisEndlessRetryPolicy implements RetryPolicy {
private static final Logger logger =
LoggerFactory.getLogger(RatisEndlessRetryPolicy.class);
- private static final RetryPolicy defaultPolicy;
-
- static {
- String str = "";
- // 50, 500ms, 40, 1000ms, 30, 1500ms, 20, 2000ms, 10, 2500ms
- int basicRetry = 50;
- int basicSleep = 500;
- for (int i = 0; i < 5; i++) {
- str += basicRetry + "," + basicSleep + ",";
- basicRetry -= 10;
- basicSleep += 500;
- }
+ private final RetryPolicy defaultPolicy;
+ RatisEndlessRetryPolicy() {
+ // about 1 hour wait Time.
defaultPolicy =
- MultipleLinearRandomRetry.parseCommaSeparated(str.substring(0,
str.length() - 1));
+ RetryPolicies.retryForeverWithSleep(TimeDuration.valueOf(2,
TimeUnit.SECONDS));
}
Review Comment:
1. if reply return false, then resend request after 2s. Instead of sending
it every 2 seconds
2. sorry, I forget delete comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
