SteveYurongSu commented on code in PR #13400:
URL: https://github.com/apache/iotdb/pull/13400#discussion_r1749990205
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java:
##########
@@ -194,9 +194,10 @@ public static boolean isPointDeleted(long timestamp,
List<TimeRange> deletionLis
public static boolean isDeviceDeletedByMods(
Collection<Modification> modifications, IDeviceID device, long
startTime, long endTime)
throws IllegalPathException {
+ final MeasurementPath deviceWithWildcard = new MeasurementPath(device,
ONE_LEVEL_PATH_WILDCARD);
for (Modification modification : modifications) {
- PartialPath path = modification.getPath();
- if (path.include(new MeasurementPath(device,
IoTDBConstant.ONE_LEVEL_PATH_WILDCARD))
+ MeasurementPath path = modification.getPath();
+ if (path.matchFullPath(deviceWithWildcard)
Review Comment:
I do not think calling matchFullPath here is correct after I read the Java
doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
