YC27 commented on code in PR #13705:
URL: https://github.com/apache/iotdb/pull/13705#discussion_r1796515980
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/load/LoadSingleTsFileNode.java:
##########
@@ -202,16 +202,16 @@ public String toString() {
+ '}';
}
- public void clean() {
+ public void clean(final boolean isLoadSuccess) {
Review Comment:
> Since a false "isLoadSuccess" will just skip the whole function, why don't
we just judge outside?
Both methods are acceptable. Two if statements need to be added to the
external judgment. There are already many if statements in the calling place,
so they are done in clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
