liyuheng55555 commented on code in PR #13660:
URL: https://github.com/apache/iotdb/pull/13660#discussion_r1797561766
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/client/sync/SyncDataNodeClientPool.java:
##########
@@ -58,20 +62,97 @@ public class SyncDataNodeClientPool {
private final IClientManager<TEndPoint, SyncDataNodeInternalServiceClient>
clientManager;
+ protected ImmutableMap<
+ CnToDnSyncRequestType,
+ CheckedBiFunction<Object, SyncDataNodeInternalServiceClient, Object,
Exception>>
+ actionMap;
+
private SyncDataNodeClientPool() {
clientManager =
new IClientManager.Factory<TEndPoint,
SyncDataNodeInternalServiceClient>()
.createClientManager(
new
ClientPoolFactory.SyncDataNodeInternalServiceClientPoolFactory());
+ buildActionMap();
+ checkActionMapCompleteness();
+ }
+
+ private void buildActionMap() {
+ ImmutableMap.Builder<
+ CnToDnSyncRequestType,
+ CheckedBiFunction<Object, SyncDataNodeInternalServiceClient,
Object, Exception>>
+ actionMapBuilder = ImmutableMap.builder();
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.INVALIDATE_PARTITION_CACHE,
+ (req, client) -> client.invalidatePartitionCache((TInvalidateCacheReq)
req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.INVALIDATE_SCHEMA_CACHE,
+ (req, client) -> client.invalidateSchemaCache((TInvalidateCacheReq)
req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.CREATE_SCHEMA_REGION,
+ (req, client) -> client.createSchemaRegion((TCreateSchemaRegionReq)
req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.CREATE_DATA_REGION,
+ (req, client) -> client.createDataRegion((TCreateDataRegionReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.DELETE_REGION,
+ (req, client) -> client.deleteRegion((TConsensusGroupId) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.INVALIDATE_PERMISSION_CACHE,
+ (req, client) ->
client.invalidatePermissionCache((TInvalidatePermissionCacheReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.CLEAN_DATA_NODE_CACHE,
+ (req, client) -> client.cleanDataNodeCache((TCleanDataNodeCacheReq)
req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.STOP_DATA_NODE, (req, client) ->
client.stopDataNode());
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.SET_SYSTEM_STATUS,
+ (req, client) -> client.setSystemStatus((String) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.KILL_QUERY_INSTANCE,
+ (req, client) -> client.killQueryInstance((String) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.UPDATE_TEMPLATE,
+ (req, client) -> client.updateTemplate((TUpdateTemplateReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.UPDATE_TABLE,
+ (req, client) -> client.updateTable((TUpdateTableReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.CREATE_NEW_REGION_PEER,
+ (req, client) -> client.createNewRegionPeer((TCreatePeerReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.ADD_REGION_PEER,
+ (req, client) -> client.addRegionPeer((TMaintainPeerReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.REMOVE_REGION_PEER,
+ (req, client) -> client.removeRegionPeer((TMaintainPeerReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.DELETE_OLD_REGION_PEER,
+ (req, client) -> client.deleteOldRegionPeer((TMaintainPeerReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.RESET_PEER_LIST,
+ (req, client) -> client.resetPeerList((TResetPeerListReq) req));
+ actionMapBuilder.put(
+ CnToDnSyncRequestType.SHOW_CONFIGURATION, (req, client) ->
client.showConfiguration());
+ actionMap = actionMapBuilder.build();
+ }
+
+ private void checkActionMapCompleteness() {
+ List<CnToDnSyncRequestType> lackList =
+ Arrays.stream(CnToDnSyncRequestType.values())
+ .filter(type -> !actionMap.containsKey(type))
+ .collect(Collectors.toList());
+ if (!lackList.isEmpty()) {
+ LOGGER.error("These request types should be added to actionMap: {}",
lackList);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
